Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Update the message to be consistent with the Django `HttpResponseBa… #9287

Merged
merged 1 commit into from
Mar 17, 2024
Merged

- Update the message to be consistent with the Django `HttpResponseBa… #9287

merged 1 commit into from
Mar 17, 2024

Conversation

maycuatroi
Copy link
Contributor

Description

I encountered an error with the assert statement due to incorrect logging. Upon reviewing the HttpResponseBase class, I discovered that its subclass should be StreamingHttpResponse instead of HttpStreamingResponse.
image

Reference: https://github.com/django/django/blob/b231bcd19e57267ce1fc21d42d46f0b65fdcfcf8/django/http/response.py#L432

@maycuatroi
Copy link
Contributor Author

image
Ref official document

@auvipy auvipy added this to the 3.15 milestone Mar 17, 2024
@auvipy auvipy merged commit 337ba21 into encode:master Mar 17, 2024
9 checks passed
@auvipy auvipy added the Bug label Mar 17, 2024
@maycuatroi maycuatroi deleted the patch-1 branch March 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.
2 participants
@maycuatroi @auvipy