-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate packaging to pyproject.toml #9056
base: master
Are you sure you want to change the base?
migrate packaging to pyproject.toml #9056
Conversation
6344069
to
42d468b
Compare
OK, it's almost ready except:
|
8c65e6d
to
6e67258
Compare
This is unrelated to your PR and I fixed it with #9129 |
6e67258
to
b16826c
Compare
Wow. It works indeed. Thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to hold this off for now. As we got other priorities.
Sure. A vague estimation of when it would become envisageable ? |
To merge after #9210, I hope. |
it was automatically migrated but flake8 doesn't support the pyproject.toml format
zip-safe is deprecated and doesn't do anything. exclude 'tests*' is already the default behaviour
12a5a0b
to
cf25dcd
Compare
watch-out: this PR is intended to be squash-merged |
So... this is a good example of a nice little pr that's a bit stalled. I don't really have any extra bandwidth to keep this moving, given existing commitments. Should we be having a discussion about getting the project into jazzband.co so that we've got a lower barrier of entry for new maintainers? |
Hey, that's a very interesting decision that is (way) beyond the scope of my humble little PR. Maybe let's open a dedicated issue ou GitHub discussion? |
pyproject.toml
Outdated
"Operating System :: OS Independent", | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in the current state, indeed
This reverts commit c2062da.
So, for remember, python 3.6 support is removed in this PR because of setuptools > 61.2 which is required for pyproject.toml support, does not support python 3.6. Technically I could do a version of this PR were DRF could not be built on python 3.6 anymore, but still be installed on it, but that would be I think a lot of CI work, and it's simpler to just wait 3 months. To hold until Django 5.2 is released, then. |
No. |
@auvipy what do you propose then? DRF has been zombie for at least 2 years. PRs are not reviewed, questions are not answered. |
Can we reconsider this in the priorities of the project to reflect the latest changes in the Python environment and the problem which was caused by |
88a9c7f
to
6f8da97
Compare
Just an initiative of my own.