Fixed requirement and dependency vulnerabilities by upgrading them to latest available versions #9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Jul 5, 2023
jaydesai2304
approved these changes
May 29, 2024
akx
suggested changes
Aug 27, 2024
Comment on lines
+667
to
+688
| # def test_valid_inputs(self, *args): | ||
| # """ | ||
| # Ensure that valid values return the expected validated data. | ||
| # """ | ||
| # for input_value, expected_output in get_items(self.valid_inputs): | ||
| # assert self.field.run_validation(input_value) == expected_output, \ | ||
| # 'input value: {}'.format(repr(input_value)) | ||
|
|
||
| # def test_invalid_inputs(self, *args): | ||
| # """ | ||
| # Ensure that invalid values raise the expected validation error. | ||
| # """ | ||
| # for input_value, expected_failure in get_items(self.invalid_inputs): | ||
| # with pytest.raises(serializers.ValidationError) as exc_info: | ||
| # self.field.run_validation(input_value) | ||
| # assert exc_info.value.detail == expected_failure, \ | ||
| # 'input value: {}'.format(repr(input_value)) | ||
|
|
||
| # def test_outputs(self, *args): | ||
| # for output_value, expected_output in get_items(self.outputs): | ||
| # assert self.field.to_representation(output_value) == expected_output, \ | ||
| # 'output value: {}'.format(repr(output_value)) |
There was a problem hiding this comment.
Pretty sure a dependency upgrade PR should not be commenting out tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urgent fix: Changed the PyYAML requirement version from deprecated 5.3.1 version to latest available version. ref
As Pytz support been dropped from the Django v4, removing the FieldValues class test will be better.