Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(require): use file-eval #15

Merged
merged 1 commit into from
Oct 11, 2016
Merged

refactor(require): use file-eval #15

merged 1 commit into from
Oct 11, 2016

Conversation

blond
Copy link
Member

@blond blond commented Oct 11, 2016

No description provided.

@blond blond merged commit 74a5779 into master Oct 11, 2016
@blond blond deleted the file-eval branch October 11, 2016 20:57
@blond blond removed the in progress label Oct 11, 2016
qfox
qfox reviewed Oct 11, 2016
View reviewed changes
Copy link
Contributor

@qfox qfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты сломал апи ;(

lib/mock-node.js
return asyncFs.read(filename, 'utf-8').then(function (source) {
return safeEval(source, filename, options.context);
});
return fileEval(filename);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

контекст пропал

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернул: 961af83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qfox qfox qfox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blond @qfox