Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logger #1

Merged
merged 4 commits into from
Jun 24, 2015
Merged

Fixed logger #1

merged 4 commits into from
Jun 24, 2015

Conversation

blond
Copy link
Member

@blond blond commented Jun 23, 2015

  • Added target param to logWarningAction method.
  • Added target param to logTechIsDeprecated method.
  • Added logOptionIsDeprecated method.

@blond blond added the review label Jun 23, 2015
@blond
Copy link
Member Author

blond commented Jun 23, 2015

/cc @tormozz48 @tavriaforever @sipayRT

@tavriaforever
Copy link

Could you add details of why this was done?

@blond
Copy link
Member Author

blond commented Jun 23, 2015

Native logger and mock of logger have different API. This PR fixed it.

@blond blond self-assigned this Jun 24, 2015
@blond
Copy link
Member Author

blond commented Jun 24, 2015

Если главной целью задачи является добавления отсутствующих методов в логгере между enb и mock версией, тогда почему код разный? Сюдя по оригиналу, здесь не хватает проверки опции hideWarnings aли так задумывалось?) https://github.com/enb-make/enb/blob/master/lib/logger.js#L83

Добавил опцию hideWarnings.

@tavriaforever
Copy link

Мне ок

@sipayRT
Copy link

sipayRT commented Jun 24, 2015

👍

blond added a commit that referenced this pull request Jun 24, 2015
@blond blond merged commit 76ba4cd into master Jun 24, 2015
@blond blond removed the review label Jun 24, 2015
@blond blond deleted the fix-logger branch June 24, 2015 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants