-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRN-16762: Added support for tailwindcss and update dependencies #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikyungKim
reviewed
Mar 21, 2022
MikyungKim
reviewed
Mar 21, 2022
MikyungKim
changed the title
WRN-16762: Apply changes from CreactReactApp 5.0
WRN-16762: Added support for tailwindcss and update dependencies
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not change the permission of bin/enact.js to 644. Please revert the change.
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
MikyungKim
reviewed
Mar 22, 2022
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
MikyungKim
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hong6316
added a commit
that referenced
this pull request
Mar 23, 2022
* WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Fixed serve issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Added webpack cache config Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * applied more changes Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Added changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update `listen` to `startCallback` from webpack dev server Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix filename..ext issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-16762: Added support for tailwindcss and update dependencies (#263) * initial modules update(before wp5 update) * npm audit fix * Update package.json * fix lint errors * update CHANGELOG.md * Update package.json * revert CHANGELOG.mx * revert jest 27 * revert npm-shrinkwrap.json * revert pack/serve.js * for removing conflict with #262, revert versions * Update react-refresh-webpack-plugin version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update babel-jest version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update babel-plugin-dev-expression version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * remove unnecessary code * revert file permission * update dependencies * update package.json * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update package.json * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * update changelog and package.json Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
hong6316
added a commit
that referenced
this pull request
Apr 11, 2022
* WRN-18582: Migrate to webpack5 (#264) * WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Fixed serve issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Added webpack cache config Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * applied more changes Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Added changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update `listen` to `startCallback` from webpack dev server Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix filename..ext issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-16762: Added support for tailwindcss and update dependencies (#263) * initial modules update(before wp5 update) * npm audit fix * Update package.json * fix lint errors * update CHANGELOG.md * Update package.json * revert CHANGELOG.mx * revert jest 27 * revert npm-shrinkwrap.json * revert pack/serve.js * for removing conflict with #262, revert versions * Update react-refresh-webpack-plugin version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update babel-jest version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update babel-plugin-dev-expression version Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * remove unnecessary code * revert file permission * update dependencies * update package.json * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update package.json * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * update changelog and package.json Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> * WRN-12124: Remove deprecated babel-eslint module (#261) * use @babel/eslint-parser * remove babel-preset-react-app * remove @babel/eslint-parser * Revert "remove @babel/eslint-parser" This reverts commit 1b8b37e. * Revert "remove babel-preset-react-app" This reverts commit b8579cb. * Revert "use @babel/eslint-parser" This reverts commit b73146a. * babel-eslint -> @babel/eslint-parser * unpinning enact repos * remove babel-eslint related word in README.md * Update README.md * modify changelog & readme * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update README.md Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * update npm-shrinkwrap.json * update @babel/core to the same version of dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Move some dependencies to dev dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19252: Pass ProgressPlugin to VerboseLogPlugin (#265) Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-12748: Update eslint 8 related modules (#262) * update eslint 8 * eslint 8 changes strict package exports(#14706), call another method * revert js changes * Update package.json * restore eslintrc.js - 'prettier' (included 'prettier/babel', 'prettier/react') * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19694: Update to React18 (#266) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update testing library for react18 Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dev-utils branch Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * revert dev-utils version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20481: Fix screenshot test build fail (#267) * Added node-polyfill-webpack-plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * added some comments Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * link dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20481: Fix lint error and revert packages version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update change log Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved / Feature Added
Added support for tailwindcss and update and unpined dependencies.
Resolution
All dependencies updated to latest release.
create
Coerce Node versions with metadata
pack
Add support for Tailwind
Additional Considerations
Links
WRN-16762
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)