Skip to content

Commit

Permalink
PLAT-37902: Fix windows-specific ilib issues with testing (#121)
Browse files Browse the repository at this point in the history
* Use last release that used /_karma_webpack_/ middleware prefix to avoid windows drive-letter pathing issues with XHR in tests.

* Use a larger 30second mocha timeout since PhantomJS has difficulties with fast sync XHR.

* Use PhantomJS as default browser until we switch properly to HeadlessChrome/Puppeteer

Reviewed-by: Jeremy Thomas (jeremy.thomas@lge.com)
Integrated-By: Ryan Duffy (ryan.duffy@lge.com)
  • Loading branch information
JayCanuck authored and ryanjduffy committed Mar 8, 2018
1 parent 53a458d commit ce09ca8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions config/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ module.exports = function(karma) {
new EnzymeAdapterPlugin()
]
},

webpackServer: {
// please don't spam the console when running in karma!
noInfo: true,
Expand All @@ -163,7 +162,6 @@ module.exports = function(karma) {
moduleTrace: false
}
},

plugins: [
'karma-webpack',
'karma-mocha',
Expand All @@ -173,16 +171,20 @@ module.exports = function(karma) {
'karma-phantomjs-launcher',
'karma-json-reporter'
],

jsonReporter: {
stdout: true
},
client: {
mocha: {
timeout: 30000
}
},
port: 9876,
colors: true,
logLevel: karma.LOG_INFO,
browserNoActivityTimeout: 60000,
autoWatch: true,
browsers: ['Chrome'],
browsers: ['PhantomJS'],
singleRun: false
});
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"karma-mocha": "1.3.0",
"karma-phantomjs-launcher": "1.0.4",
"karma-sourcemap-loader": "0.3.7",
"karma-webpack": "2.0.9",
"karma-webpack": "2.0.6",
"less": "2.7.3",
"less-loader": "4.0.5",
"license-checker": "16.0.0",
Expand Down

0 comments on commit ce09ca8

Please sign in to comment.