Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source maps issues on windows; followup to #9882 #9925

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Fix source maps issues on windows; followup to #9882 #9925

merged 2 commits into from
Nov 30, 2019

Conversation

kripken
Copy link
Member

@kripken kripken commented Nov 29, 2019

After #9882 we don't always call .resolve, so the path
normalization must be pulled into a place that dominates
all code paths.

@kripken kripken requested a review from sbc100 November 29, 2019 23:32
@kripken kripken merged commit afc2573 into incoming Nov 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the map2 branch November 30, 2019 00:55
@kripken
Copy link
Member Author

kripken commented Nov 30, 2019

@sbc100 if this doesn't fix the windows bot I'll revert both.

belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@kripken @belraquib
Fix source maps issues on windows; followup to emscripten-core#9882 (e…
fc8d323 
…mscripten-core#9925)

After emscripten-core#9882 we don't always call .resolve, so the path
normalization must be pulled into a place that dominates
all code paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @sbc100