Add llvm.minnum.f(32|64) and llvm.maxnum.f(32|64) intrinsics #5978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkor
added a commit
to varkor/emscripten-fastcomp
that referenced
this pull request
Dec 23, 2017
The corresponding change to Emscripten is this PR: emscripten-core/emscripten#5978, and relates to this issue: emscripten-core/emscripten#5976. I’m using emscripten-core#143 as a model.
This was referenced Dec 23, 2017
Add llvm.minnum.f(32|64) and llvm.maxnum.f(32|64) intrinsics
emscripten-core/emscripten-fastcomp#210
Merged
varkor
force-pushed
the
minnum-maxnum-intrinsics
branch
from
50554a2 to
6248783
Compare
kripken
reviewed
Dec 28, 2017
| @@ -1582,6 +1582,10 @@ LibraryManager.library = { | |||
| llvm_floor_f64: 'Math_floor', | |||
| llvm_round_f32: 'Math_round', | |||
| llvm_round_f64: 'Math_round', | |||
| llvm_minnum_f32: 'Math_min', | |||
| llvm_minnum_f64: 'Math_min', | |||
| llvm_maxnum_f32: 'Math_max', | |||
There was a problem hiding this comment.
the maxnum ones seem to have already existed (line 4375). Your addition is in a better location, though, let's remove the old ones.
There was a problem hiding this comment.
Not sure how I missed those! Updated, thanks.
varkor
force-pushed
the
minnum-maxnum-intrinsics
branch
from
6248783 to
3d67088
Compare
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
varkor
force-pushed
the
minnum-maxnum-intrinsics
branch
from
19dca5d to
87ff06a
Compare
varkor
added a commit
to varkor/emscripten-fastcomp
that referenced
this pull request
Dec 28, 2017
The corresponding change to Emscripten is this PR: emscripten-core/emscripten#5978, and relates to this issue: emscripten-core/emscripten#5976. I’m using emscripten-core#143 as a model.
|
Great, thanks! |
kripken
pushed a commit
to emscripten-core/emscripten-fastcomp
that referenced
this pull request
Jan 5, 2018
The corresponding change to Emscripten is this PR: emscripten-core/emscripten#5978, and relates to this issue: emscripten-core/emscripten#5976.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5976. I’m using #4353 as a model.