[jsifier] Simplify stub function handling #25519
Merged
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 7, 2025
| // We have already warned/errored about this function, so for the purposes of Closure use, mute all type checks | ||
| // regarding this function, marking ot a variadic function that can take in anything and return anything. | ||
| // (not useful to warn/error multiple times) | ||
| LibraryManager.library[symbol + '__docs'] = '/** @type {function(...*):?} */'; |
There was a problem hiding this comment.
Is this not needed for some reason?
There was a problem hiding this comment.
Seems like its no longer needed, since closure can see the ... in the function body I believe.
There was a problem hiding this comment.
Since we are not always creating the stubs with new Function('...args') closure can see that the function variadic.
kripken
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.