Improve testing of liblegacy.js. NFC #25515
Merged
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some testing for `LEGACY_RUNTIME` but not explicitly for the usage of symbols in `liblegacy.js` which are two slightly different things.
dschuff
reviewed
Oct 7, 2025
| $allocateUTF8: '$stringToNewUTF8', | ||
| $allocateUTF8OnStack: '$stringToUTF8OnStack', | ||
| $allocateUTF8__deps: ['$stringToNewUTF8'], | ||
| $allocateUTF8: (...args) => stringToNewUTF8(...args), |
There was a problem hiding this comment.
what does this part actually do?
There was a problem hiding this comment.
I changed these from simple aliases to wrapper functions.
The aliases were bypassing the JS library symbol '${name}' is deprecated warning injections mechanism below.
dschuff
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some testing for
LEGACY_RUNTIMEbut not explicitly for the usage of symbols inliblegacy.jswhich are two slightly different things.