[WASMFS] Fix remaining TODO items with wasmfs + noderawfs #23617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Feb 7, 2025
sbc100
changed the title
@with_all_fs. NFC
|
I ended up just fixing the resulting failures, so this change now includes a bunch of wasmfs fixes. |
|
@hoodmane I think we getting close to feature parity with wasmfs after this change. Maybe you could give it a try soon? |
kripken
reviewed
Feb 7, 2025
sbc100
force-pushed
the
wasmfs_rawfs
branch
3 times, most recently
from
7c80380 to
034f631
Compare
kripken
approved these changes
Feb 7, 2025
In order make sure this gets tested I added the combination of wasmfs and rawfs to `@with_all_fs`.
|
Okay. I will try building python against wasmfs and see what happens in the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order make sure this gets tested I added the combination of wasmfs
and rawfs to
@with_all_fs.Fixes: #23618