Allow minification of pthread postMessage objects. NFC #22555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Sep 10, 2024
In the part using unquoted key here meant that closure would minify these key and this was a problem because the separate worker.js files would not then be able to interpret them. However since emscripten-core#21701 landed there is no longer separate worker.js file so closure can minify these keys and it will effect both sending and receiving code.
sbc100
force-pushed
the
minify_pthread_messages
branch
from
b8635cd
to
7ebce73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the part using unquoted key here meant that closure would minify these key and this was a problem because the separate worker.js files would not then be able to interpret them.
However since #21701 landed there is no longer separate worker.js file so closure can minify these keys and it will effect both sending and receiving code.