Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pthread + modularize + running in node worker #21832

Merged
merged 1 commit into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Fix pthread + modularize + running in node worker

    The issue here was the special case for the setting of `scriptDirectory`
    under nodejs when `ENVIRONMENT_IS_WORKER`.
    
    Previously this path was not being hit when the main thread was running
    in a worker because we were not setting `ENVIRONMENT_IS_WORKER` in this
    case.  This was fixed in emscripten-core#21701 and `ENVIRONMENT_IS_WORKER` was
    correctly set, but that meant that `scriptDirectory` then started being
    set incorrectly.
    
    Fixes: emscripten-core#21827
    sbc100 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bd19c93 View commit details
    Browse the repository at this point in the history