embind: Use single type object for emval. #20806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Nov 30, 2023
brendandahl
force-pushed
the
tsgen-reuse-val
branch
4 times, most recently
from
f20db67 to
86556f7
Compare
|
Sorry, I don't remember why its OK to loose the |
It will always be |
sbc100
approved these changes
Dec 6, 2023
|
Looks like you need to run |
brendandahl
force-pushed
the
tsgen-reuse-val
branch
from
86556f7 to
6459372
Compare
If register_type is used, emval will be registered multiple times for different type id's, but only a single type object is needed on the JS side for all of them.
brendandahl
force-pushed
the
tsgen-reuse-val
branch
from
6459372 to
a12728a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If register_type is used, emval will be registered multiple times for different type id's, but only a single type object is needed on the JS side for all of them.