[wasm64] Fix a lot of the remaining browser tests #20516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_wasm64_part2
branch
14 times, most recently
from
6b89ae4 to
f74fc7e
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 26, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 26, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 27, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 27, 2023
sbc100
force-pushed
the
browser_wasm64_part2
branch
from
f74fc7e to
53205a1
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 1, 2023
Split out from emscripten-core#20516
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 1, 2023
Split out from emscripten-core#20516
sbc100
force-pushed
the
browser_wasm64_part2
branch
from
53205a1 to
765d988
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 6, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 7, 2023
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 7, 2023
As part of this EGLNativeDisplayType was fixed to match X11 This allows `Display*` (a pointer type) to be passed into our eglGetDisplay function without a cast warning on wasm64 (where pointers and int have a different width). Split out from emscripten-core#20516
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 7, 2023
As part of this EGLNativeDisplayType was fixed to match X11 This allows `Display*` (a pointer type) to be passed into our eglGetDisplay function without a cast warning on wasm64 (where pointers and int have a different width). Split out from emscripten-core#20516
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 7, 2023
As part of this EGLNativeDisplayType was fixed to match X11 This allows `Display*` (a pointer type) to be passed into our eglGetDisplay function without a cast warning on wasm64 (where pointers and int have a different width). Split out from emscripten-core#20516
sbc100
added a commit
that referenced
this pull request
Nov 7, 2023
As part of this EGLNativeDisplayType was fixed to match X11 This allows `Display*` (a pointer type) to be passed into our eglGetDisplay function without a cast warning on wasm64 (where pointers and int have a different width). Split out from #20516
sbc100
force-pushed
the
browser_wasm64_part2
branch
3 times, most recently
from
b413cce to
e2304e4
Compare
sbc100
force-pushed
the
browser_wasm64_part2
branch
3 times, most recently
from
c1a9b5d to
7e39e71
Compare
|
I think this change is now small enough to land, having split ~10 changes from it. PTAL. |
sbc100
force-pushed
the
browser_wasm64_part2
branch
from
7e39e71 to
66691bd
Compare
kripken
reviewed
Nov 8, 2023
system/lib/compiler-rt/lib/sanitizer_common/sanitizer_emscripten.cpp
Outdated
Show resolved
Hide resolved
kripken
reviewed
Nov 8, 2023
kripken
reviewed
Nov 8, 2023
This also inverts the testing logic such that we run all browser tests in wasm64 mode. Tests that don't currently pass are annotated with @no_wasm64.
sbc100
force-pushed
the
browser_wasm64_part2
branch
from
66691bd to
3995ce4
Compare
kripken
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also inverts the testing logic such that we run all browser tests in wasm64 mode. Tests that don't currently pass are annotated with @no_wasm64.