Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename asm to wasmExports under MINIMAL_RUNTIME #19901

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jul 26, 2023

This matches the name used by the regualar runtime as of #19816 and removes one of them major differences between the two runtimes.

@sbc100 sbc100 requested a review from kripken July 26, 2023 10:54
@sbc100
Copy link
Collaborator Author

sbc100 commented Jul 26, 2023

Depends on #19900

@sbc100 sbc100 force-pushed the wasmExports_minimal_runtime branch from b2f9b9c to 7a01695 Compare July 26, 2023 12:05
@sbc100 sbc100 force-pushed the wasmExports_minimal_runtime branch 2 times, most recently from 8287b65 to f2fe5d2 Compare July 26, 2023 15:19
Base automatically changed from wasmExports_part2 to main July 26, 2023 18:35
This matches the name used by the regualar runtime as of #19816 and
removes one of them major differences between the two runtimes.
@sbc100 sbc100 force-pushed the wasmExports_minimal_runtime branch from f2fe5d2 to 6406beb Compare July 26, 2023 18:38
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sbc100 sbc100 merged commit 0bf0d39 into main Jul 26, 2023
2 checks passed
@sbc100 sbc100 deleted the wasmExports_minimal_runtime branch July 26, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants