Implement MAP_ANONYMOUS on top of malloc in STANDALONE_WASM mode #16289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Feb 15, 2022
sbc100
force-pushed
the
mmap_standalone
branch
from
f2d6dec
to
d86afde
Compare
This hack already exists in the JS implementation of mmap. We could try to unify the two but I'm not sure its worth it. Fixes: #16280
sbc100
force-pushed
the
mmap_standalone
branch
from
d86afde
to
62beaf3
Compare
kripken
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack already exists in the JS implementation of mmap. We could try
to unify the two but I'm not sure its worth it.
Fixes: #16280, #13312