Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utimes from musl #16282

Merged
merged 15 commits into from
Feb 14, 2022
Merged

Use utimes from musl #16282

merged 15 commits into from
Feb 14, 2022

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 14, 2022

Followup to #16262

@kripken kripken requested a review from sbc100 February 14, 2022 21:10
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change!

@kripken kripken merged commit aa147e7 into main Feb 14, 2022
@kripken kripken deleted the utimes branch February 14, 2022 22:34
tlively added a commit to tlively/emscripten that referenced this pull request Mar 30, 2022
Upstream Emscripten switched to using musl's utime implementation in
emscripten-core#16282. That implementation
bottoms out in utimensat, which PThreadFS implements, so removing the utime
implementation should be safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants