Turn dependenciesFulfilled into an array

[dalcde]

This function returns a promise that resolves when all run dependencies are fulfilled. I use this to wait for file_packager bundles to load.

I can add documentation and tests if this feature is accepted.

[dalcde]

I've decided for my purposes, it suffices to turn dependenciesFulfilled to an array; the user can simply expose it and append to it themselves. I have renamed it to onDependenciesFulfilled to be more descriptive.

[sbc100]

What exactly are you trying to achieve? Is there some reason why the current hooks for you:

var __ATPRERUN__  = []; // functions called before the runtime is initialized                 
var __ATINIT__    = []; // functions called during startup                       
var __ATMAIN__    = []; // functions called when main() is to be run             
var __ATEXIT__    = []; // functions called during shutdown                      
var __ATPOSTRUN__ = []; // functions called after the main() is called  

If you want you code to run after all the file packages have been loaded I think __ATMAIN__ might be what you want. You can use addOnPreRun to add something to this array.

[dalcde]

What exactly are you trying to achieve?

I load new files after main has run.

[sbc100]

What exactly are you trying to achieve?
I load new files after main has run.

Then don't you want to put your callback in __ATPOSTRUN__.

Doing things during onDependenciesFulfilled happens before main, right?

[dalcde]

I meant that during runtime, users can perform actions to trigger loading new files, and I want to know when those files are loaded.

[sbc100]

I meant that during runtime, users can perform actions to trigger loading new files, and I want to know when those files are loaded.

Hmm.. I'm not sure this is the best approach "dependencies fulfilled" means "are the the dependencies of them main application fulfulled and can we now run main." If main is already running then by definition the dependencies are fulfilled. Perhaps its just a questions of renaming / refactoring but the dependencies here are for more than just files, they are for all kind of things. Its sounds like you want some kind of promise that resolves when files are asynchronously loaded at runtime?

[dalcde]

On Sun, Jan 10, 2021 at 04:30:42AM -0800, Sam Clegg wrote: > I meant that during runtime, users can perform actions to trigger loading new files, and I want to know when those files are loaded. Hmm.. I'm not sure this is the best approach "dependencies fulfilled" means "are the the dependencies of them main application fulfulled and can we now run `main`." If main is already running then by definition the dependencies are fulfilled. Perhaps its just a questions of renaming / refactoring but the dependencies here are for more than just files, they are for all kind of things. Its sounds like you want some kind of promise that resolves when files are asynchronously loaded at runtime?

That is what I'm looking for, yes. But this is generally difficult to do without modifying emscripten, possibly significantly, because the files are loaded as independent script tags. This would also have to wait for file preloading in case preload plugins are used. The runDependencies system is an already-in-place system that achieves all these.

[kripken]

A downside to generalizing the mechanism as in this PR is that it increases code size.

Can you wrap the existing callback? That is, if dependenciesFulfilled is a function (and not null), make a new function with your new code, and that also calls the old one.

[dalcde]

At the moment, this is difficult because it is hard to access dependenciesFulfilled and runDependencies in "external" code.

[stale]

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.