Add missing -fPIC to dylink test
#12220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was no a problem previously because the code in these object files didn't generate any non-PIC-compatible relocations. However, since https://reviews.llvm.org/D87537 landed in llvm all `-pie/-shared` linked binaries now require the mutable-globals feature in at least one object otherwise the link will fail with `wasm-ld: error: mutable global imported but 'mutable-globals' feature not present in inputs: '__stack_pointer'. Use --no-check-features to suppress.` Passing `-fPIC` when compiling shared library code not only produces compatible relocations but now also injects this feature into the features section.
tlively
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should always have been here but was previously not a
fatal problem because the code in these object files happens
to not generate any non-PIC-compatible relocations.
However, since https://reviews.llvm.org/D87537 landed in llvm
all
-pie/-sharedlinked binaries now require the mutable-globalsfeature in at least one object otherwise the link will fail with
wasm-ld: error: mutable global imported but 'mutable-globals' feature not present in inputs: '__stack_pointer'. Use --no-check-features to suppress.Passing
-fPICwhen compiling shared library code not onlyproduces compatible relocations but now also injects this feature
into the features section.