Initial support for multiple LLVM versions #11639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Jul 15, 2020
| @@ -17,6 +17,8 @@ See docs/process.md for how version tagging works. | |||
|
|
|||
| Current Trunk | |||
| ------------- | |||
| - A simultaneous support for both llvm 12.0 (tot) and llvm 11.0 (soon to be | |||
There was a problem hiding this comment.
Suggested change
| - A simultaneous support for both llvm 12.0 (tot) and llvm 11.0 (soon to be | |
| - Simultaneous support for both llvm 12.0 (tot) and llvm 11.0 (soon to be |
| @@ -17,6 +17,8 @@ See docs/process.md for how version tagging works. | |||
|
|
|||
| Current Trunk | |||
| ------------- | |||
| - A simultaneous support for both llvm 12.0 (tot) and llvm 11.0 (soon to be | |||
| stable). See https://github.com/emscripten-core/emscripten/issues/11362 | |||
There was a problem hiding this comment.
Suggested change
| stable). See https://github.com/emscripten-core/emscripten/issues/11362 | |
| stable). #11362 |
| @@ -412,31 +412,29 @@ def fix_js_engine(old, new): | |||
| return new | |||
|
|
|||
|
|
|||
| def expected_llvm_version(): | |||
| def supported_llvm_versions(): | |||
There was a problem hiding this comment.
perhaps a comment that they must be in order (as the callers seem to depend on that)?
| else: | ||
| return "6.0" | ||
| return ("6.0") |
There was a problem hiding this comment.
maybe ' here like above, or both with "?
|
How about we issue a different warning... I try an come up with one. |
|
Putting this on hold for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11362