Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let LLVM 12 roll in #11637

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Let LLVM 12 roll in #11637

merged 1 commit into from
Jul 15, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Jul 15, 2020

Looks like LLVM 12 was just bumped as the new version number,

https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8874713585966760400/+/steps/Emscripten_testsuite__upstream__other_/0/stdout

Is there a better way to do this than disabling the test and the check manually?

@kripken kripken requested a review from sbc100 July 15, 2020 14:15
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable approach.

@kripken kripken merged commit 61a9d08 into master Jul 15, 2020
@kripken kripken deleted the roll branch July 15, 2020 15:36
sbc100 added a commit that referenced this pull request Jan 28, 2021
This change temporarily disables the version check to allow
the llvm change to roll in.

Copied from the previous time around: #11637.
sbc100 added a commit that referenced this pull request Jan 28, 2021
This change temporarily disables the version check to allow
the llvm change to roll in.

Copied from the previous time around: #11637.
sbc100 added a commit that referenced this pull request Jan 28, 2021
This change temporarily disables the version check to allow
the llvm change to roll in.

Copied from the previous time around: #11637.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants