Warn when using -g in combination with -sASYNCIFY
#13288
Comments
|
@kripken is this true? If it is then I guess that is a binaryen bug.. is it fixable? If not, should we just ban that combination completely for now? |
kripken
added a commit
to WebAssembly/binaryen
that referenced
this issue
Jan 20, 2021
kripken
added a commit
to WebAssembly/binaryen
that referenced
this issue
Jan 26, 2021
Previously the addDefault* methods would avoid adding opt passes that we know are incompatible with DWARF. However, that didn't handle the case of passes that are added in other ways. For example, when running Asyncify, emcc will run --flatten before, and that pass is not compatible with DWARF. This PR lets us warn on that by annotating the passes themselves. Then we use those annotation to either not run a pass at all (matching the previous behavior) or to show a warning when necessary. Fixes emscripten-core/emscripten#13288 . That is, concretely after this PR running asyncify + DWARF will show a warning to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using
-sASYNCIFY(or any other feature that involves complex program rewriting / optimizations via Binaryen) combined with-g, it'd be great to haveemccspit out a warning to let the developer know that what they are trying to do might not work, since the DWARF data is not updated correctly.The text was updated successfully, but these errors were encountered: