Skip to content

Commit

Permalink
embind: Ensure embind works under c++11.
Browse files Browse the repository at this point in the history
We no longer need to test c++17 since that is the default used, but we
should ensure we maintain compatibility with c++11.
  • Loading branch information
brendandahl committed Jan 18, 2024
1 parent e6415d6 commit f0d126e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -2972,8 +2972,8 @@ def test_embind_closure_no_dynamic_execution(self):
})
@parameterized({
'': [],
# Ensure embind compiles under C++17 where "noexcept" became part of the function signature.
'cxx17': ['-std=c++17'],
# Ensure embind compiles under C++11 which is the miniumum supported version.
'cxx11': ['-std=c++11'],
'o1': ['-O1'],
'o2': ['-O2'],
'o2_mem_growth': ['-O2', '-sALLOW_MEMORY_GROWTH', test_file('embind/isMemoryGrowthEnabled=true.cpp')],
Expand Down

0 comments on commit f0d126e

Please sign in to comment.