Skip to content

Commit

Permalink
Fix test_cubegeom_pre_relocatable (#21240)
Browse files Browse the repository at this point in the history
This test was broken by #21103 but when unnoticed because we run our
browser tests with swiftshader enabled, which skips this test.
  • Loading branch information
sbc100 authored Feb 2, 2024
1 parent 8747ab0 commit 380a9dd
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/test_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -2085,7 +2085,10 @@ def test_cubegeom_pre_regal(self):
@requires_graphics_hardware
@no_swiftshader
def test_cubegeom_pre_relocatable(self):
self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL', '-sRELOCATABLE'])
# RELOCATABLE needs to be set via `set_setting` so that it will also apply when
# building `browser_reporting.c`
self.set_setting('RELOCATABLE')
self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL'])

@requires_graphics_hardware
@no_swiftshader
Expand Down

0 comments on commit 380a9dd

Please sign in to comment.