Mention tagName option into README.md #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned [in this issue](empress#72), this seems to render the markdown without the `ember-view` div wrapper. Didn't tried yet, just saw that opened issue that may be worth mentioning in the readme. Maybe @sheriffderek you can confirm this worked for you ?
|
This is actually not possible any more 😞 I think we could do a PR that actually removes the surrounding div that we added when moving to glimmer and release it as a major if people are still interested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue, this seems to render the markdown without the
ember-viewdiv wrapper.Didn't tried yet, just saw that opened issue that may be worth mentioning in the readme.
Maybe @sheriffderek you can confirm this worked for you ?
Of course, feel free to suggest update for the wording or code example provided here if you feel it can be better 😃