Skip to content

Commit

Permalink
Fixed undefined constant in installer (OpenMage#3259)
Browse files Browse the repository at this point in the history
* Fixed undefined constant

* Update phpstan.dist.baseline.neon

---------

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
  • Loading branch information
sreichel and fballiano committed May 15, 2023
1 parent f12eb44 commit 428a8ec
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion app/code/core/Mage/Install/Model/Installer.php
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ public function createAdministrator($data)
//to support old logic checking if real data was passed
if (is_array($data)) {
$data = $this->validateAndPrepareAdministrator($data);
if (is_array(data)) {
if (is_array($data)) {
throw new Exception(Mage::helper('install')->__('Please correct the user data and try again.'));
}
}
Expand Down
5 changes: 0 additions & 5 deletions phpstan.dist.baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -3220,11 +3220,6 @@ parameters:
count: 1
path: app/code/core/Mage/Install/Model/Config.php

-
message: "#^Constant data not found\\.$#"
count: 1
path: app/code/core/Mage/Install/Model/Installer.php

-
message: "#^Method Mage_Install_Model_Installer\\:\\:getDataModel\\(\\) should return Mage_Install_Model_Session but returns Mage_Install_Model_Installer_Data\\|null\\.$#"
count: 1
Expand Down

0 comments on commit 428a8ec

Please sign in to comment.