[weak-memoize] Convert to TypeScript #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ab2cf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Not sure what happened to the codesandbox. Going to the |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ab2cf1:
|
sarayourfriend
commented
Aug 15, 2021
packages/weak-memoize/src/index.ts
Outdated
Comment on lines
7
to
9
| // Use non-null assertion because we just checked that the cache `has` it | ||
| // This allows us to remove `undefined` from the return value | ||
| return cache.get(arg) as Return | ||
| return cache.get(arg)! |
There was a problem hiding this comment.
Ahh, TIL about the non-null assertion, thank you @Andarist
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Converts
weak-memoizeto TypeScript.Why:
Part of #2358
How:
Rename
index.jstoindex.tsand add types.Checklist:
Requires some changes from #2427 to get the jest tests to run, but figured I'd put this one anyway to get it started.