Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with styled transformer not respecting autoLabel: 'dev-only' setting #2157

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Fixed an issue with styled transformer not respecting autoLabel: 'dev-only' setting #2157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4e4c5
Fixed an issue with `styled` transformer not respecting `autoLabel: '…
Andarist Dec 3, 2020
2aafb6b
Merge branch 'master' into fix/styled-options-dev-only-label
Andarist Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-trainers-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@emotion/babel-plugin': patch
---

Fixed an issue with `styled` transformer not respecting `autoLabel: 'dev-only'` setting.
12 changes: 9 additions & 3 deletions packages/babel-plugin/__tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ import _styled from \\"@emotion/styled/base\\";
function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

// @flow
const MyComponent = _styled(\\"div\\", {
const MyComponent = _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"eck06en0\\"
} : {
target: \\"eck06en0\\",
label: \\"MyComponent\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand All @@ -29,7 +31,9 @@ const MyComponent = _styled(\\"div\\", {
toString: _EMOTION_STRINGIFIED_CSS_ERROR__
});

const OtherComponent = MyComponent.withComponent('section', {
const OtherComponent = MyComponent.withComponent('section', process.env.NODE_ENV === \\"production\\" ? {
target: \\"eck06en1\\"
} : {
target: \\"eck06en1\\",
label: \\"OtherComponent\\"
});"
Expand Down Expand Up @@ -268,7 +272,9 @@ function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to string
import * as React from 'react';
import { jsx } from '@emotion/react';
const MyObject = {
MyProperty: _styled(\\"div\\", {
MyProperty: _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"erl9uiw0\\"
} : {
target: \\"erl9uiw0\\",
label: \\"MyProperty\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand Down
96 changes: 72 additions & 24 deletions packages/babel-plugin/__tests__/__snapshots__/styled.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/babel-plugin/__tests__/disable-source-map/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ import _styled from \\"@emotion/styled/base\\";

function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

let Comp = _styled(\\"div\\", {
let Comp = _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"eggnygh0\\"
} : {
target: \\"eggnygh0\\",
label: \\"Comp\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand Down
8 changes: 6 additions & 2 deletions packages/babel-plugin/__tests__/import-mapping/__snapshots__/import-mapping.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ let SomeComp = nonDefaultStyled.div({ color: 'hotpink' })
function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

import { nonDefaultStyled } from 'package-one';
let SomeComp = nonDefaultStyled(\\"div\\", {
let SomeComp = nonDefaultStyled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"e1dq5q4a0\\"
} : {
target: \\"e1dq5q4a0\\",
label: \\"SomeComp\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand All @@ -110,7 +112,9 @@ import { something as _styled } from \\"package-four/base\\";

function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

let SomeComp = _styled(\\"div\\", {
let SomeComp = _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"e16az05m0\\"
} : {
target: \\"e16az05m0\\",
label: \\"SomeComp\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand Down
8 changes: 6 additions & 2 deletions packages/babel-plugin/__tests__/source-maps/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ import _styled from \\"@emotion/styled/base\\";

function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

const SomeComponent = _styled(\\"div\\", {
const SomeComponent = _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"eb28ebz0\\"
} : {
target: \\"eb28ebz0\\",
label: \\"SomeComponent\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand Down Expand Up @@ -221,7 +223,9 @@ import _styled from \\"@emotion/styled/base\\";

function _EMOTION_STRINGIFIED_CSS_ERROR__() { return \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; }

const SomeComponent = _styled(\\"div\\", {
const SomeComponent = _styled(\\"div\\", process.env.NODE_ENV === \\"production\\" ? {
target: \\"eb28ebz0\\"
} : {
target: \\"eb28ebz0\\",
label: \\"SomeComponent\\"
})(process.env.NODE_ENV === \\"production\\" ? {
Expand Down
Loading