Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages (next) #1982

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Version Packages (next) #1982

merged 1 commit into from
Sep 8, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 21, 2020

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

next is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on next.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

@emotion/styled@11.0.0-next.16

Minor Changes

  • 18c0d5f4 #1668 Thanks @animecyc! - Custom shouldForwardProp is being preserved now when using .withComponent. Also, when passing an additional shouldForwardProp in .withComponent's options (like this: SomeComponent.withComponent('span', { shouldForwardProp })) it's being composed with the potentially existing shouldForwardProp.

Patch Changes

  • 23faf9ef #1996 Thanks @Andarist! - Fixed an issue with wrapped class components not having a type for the ref prop.

  • 0895f1f3 #1995 Thanks @Andarist! - Fixed an issue with typing for the as prop not being provided to components created using component factories available on the styled factory (e.g. styled.div).

  • Updated dependencies [debaad9a, 58b2bbca]:

    • @emotion/utils@1.0.0-next.1
    • @emotion/react@11.0.0-next.16
    • @emotion/serialize@0.11.15-next.4
    • @emotion/babel-plugin@11.0.0-next.16

@emotion/babel-plugin@11.0.0-next.16

Patch Changes

  • Updated dependencies []:
    • @emotion/serialize@0.11.15-next.4

@emotion/cache@11.0.0-next.16

Patch Changes

  • a8eb4e75 #1998 Thanks @Andarist! - Styles are now correctly extracted from the correct cache (key-sensitive) on the server.

  • dfe98028 #2003 Thanks @Andarist! - Fixed an issue with orphaned pseudo selectors (e.g. :hover - where &:hover, div:hover, etc are not considered orphaned) having the context selector (the one computed based on all ancestor levels selectors) doubled in a descendant at-rule.

  • 39be057b #1997 Thanks @Andarist! - From now on an empty rule will get inserted into the DOM in non-production environments if it gets created by the user. This helps to grab used keys from the (JS)DOM even for caches that have not inserted any actual rules to the document yet. It allows @emotion/jest to find those and serialize Emotion classes properly in situations like this:

    import styled from '@emotion/styled/macro'
    import { render } from '@testing-library/react'
    const Div = styled.div``
    test('foo', () => {
      const { container } = render(<Div />)
      expect(container).toMatchSnapshot()
    })
  • Updated dependencies [debaad9a, 39be057b]:

    • @emotion/utils@1.0.0-next.1
    • @emotion/sheet@1.0.0-next.4

@emotion/css@11.0.0-next.16

Patch Changes

  • Updated dependencies [a8eb4e75, dfe98028, debaad9a, 39be057b, 39be057b]:
    • @emotion/cache@11.0.0-next.16
    • @emotion/utils@1.0.0-next.1
    • @emotion/sheet@1.0.0-next.4
    • @emotion/serialize@0.11.15-next.4
    • @emotion/babel-plugin@11.0.0-next.16

@emotion/native@11.0.0-next.16

Patch Changes

  • Updated dependencies []:
    • @emotion/primitives-core@11.0.0-next.16

@emotion/primitives@11.0.0-next.16

Patch Changes

  • Updated dependencies []:
    • @emotion/primitives-core@11.0.0-next.16
    • @emotion/babel-plugin@11.0.0-next.16

@emotion/primitives-core@11.0.0-next.16

Patch Changes

  • Updated dependencies [58b2bbca]:
    • @emotion/react@11.0.0-next.16

@emotion/react@11.0.0-next.16

Patch Changes

  • 58b2bbca #1981 Thanks @Andarist! - Changed the key of the global flag that helps us identify that @emotion/react has been loaded more than once to include the current major version of @emotion/react.

  • Updated dependencies [a8eb4e75, dfe98028, debaad9a, 39be057b, 39be057b]:

    • @emotion/cache@11.0.0-next.16
    • @emotion/utils@1.0.0-next.1
    • @emotion/sheet@1.0.0-next.4
    • @emotion/serialize@0.11.15-next.4

@emotion/serialize@0.11.15-next.4

Patch Changes

  • Updated dependencies [debaad9a]:
    • @emotion/utils@1.0.0-next.1

@emotion/server@11.0.0-next.16

Patch Changes

  • Updated dependencies [debaad9a]:
    • @emotion/utils@1.0.0-next.1
    • @emotion/css@11.0.0-next.16

@emotion/sheet@1.0.0-next.4

Patch Changes

  • 39be057b #1997 Thanks @Andarist! - Reverted the change that has started to add an empty <style/> element eagerly in non-production environments that has been introduced in v1.0.0-next.3 as this has found to be problematic for websites using Content-Security-Policy and a nonce. Instead of this @emotion/cache will from now on insert an empty rule in non-production environments but it will only do that if an empty rule gets actually created by the user.

@emotion/utils@1.0.0-next.1

Patch Changes

  • debaad9a #1999 Thanks @RoystonS! - Fixed TypeScript definition of the EmotionCache by replacing the non-existent stylis method with insert that is available at runtime.

@emotion/jest@11.0.0-next.16

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2c0323:

Sandbox Source
Emotion Configuration

@github-actions github-actions bot force-pushed the changeset-release/next branch from ea80a8b to 886ff90 Compare August 21, 2020 20:55
@github-actions github-actions bot force-pushed the changeset-release/next branch 7 times, most recently from f6ca046 to ee0b9fe Compare September 8, 2020 11:08
@github-actions github-actions bot force-pushed the changeset-release/next branch from ee0b9fe to b2c0323 Compare September 8, 2020 11:22
@Andarist
Copy link
Member

Andarist commented Sep 8, 2020

Merging in - new releases should be available soon, cc @RoystonS

@Andarist Andarist merged commit 8307133 into next Sep 8, 2020
@Andarist Andarist deleted the changeset-release/next branch September 8, 2020 11:31
@RoystonS
Copy link
Contributor

RoystonS commented Sep 8, 2020

@Andarist Thanks. Was the change to @emotion/serialize, going from 1.0.0-next.3 to 0.11.15-next.4 intentional? That's causing some issues as 0.11.16 is the Emotion 10 version of serialize, so the packages requesting "^0.11.15-next.4" specifiers are actually getting the Emotion 10 version.

https://github.com/emotion-js/emotion/pull/1982/files#diff-952b2502c559076ccbc416c87399bf09R3

@Andarist
Copy link
Member

Andarist commented Sep 8, 2020

No, it was not - Changesets had to compute something wrongly. There were cases like this in the past but I thought that we have resolved all of them - gonna look into this in a moment, but it's nearly midnight here so I might not be able to fix this today. We'll see.

@Andarist
Copy link
Member

Andarist commented Sep 8, 2020

I think I've identified the problem in Changesets. It has actually been already fixed (changesets/changesets#446) by me a few weeks ago but it has not been reviewed and merged in yet 😅

Anyway - I've just added prepared a release that should fix it: #2006 . Going to sleep though, so 🤞

EDIT:// unfortunately, something went wrong with that release :S we'll have to debug this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants