Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some changeset bump types and do a few changeset cleanups #1980

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

Andarist
Copy link
Member

closes #1471

I've promoted @emotion/is-prop-valid & @emotion/serialize to v1. While this isn't technically necessary and doesn't really help #1471 anyhow as any, previously, minor bump will just have to be a major bump now so nothing changes in regards to possibly duplicated modules. However, I kinda have started to consider 0.x versions harmful - they require a slightly different mindset and when managing a monorepo I just don't want to focus on that.

Changesets also do not differentiate them - so while major bumping you get a nice helpful message about what should be put into a changeset, but when minor bumping 0.x (which is a similar situation) you don't get any such message.

It also makes it less apparent that you might end up with weird situations when managing 2 release lines (master & next) such as the one reported here: #1974 . Making those packages v1+ doesn't, of course, solve this problem entirely - but I feel one is way more vigilant about cases like this when working with >=1.0 packages and thus it makes it harder to run into such problems.

I haven't touched some packages that are still at 0.x stage as there is only a low chance for them to ever be upgraded - like @emotion/memoize. And even if we decide to upgrade them, for whatever reason, then it won't really matter if we upgrade them with a minor or with a major bump, both mean a breaking change for them, so I have concluded that it's not worth creating weird changelog entries right now just for a sake of upgrading them.

Also - I've cleaned up a few changeset files just a little bit. Just some random things I've spotted when reviewing existing changesets. More cleanups will be required before releasing v11.

@Andarist Andarist requested a review from emmatown August 21, 2020 18:57
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2020

💥 No Changeset

Latest commit: ba2e288

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba2e288:

Sandbox Source
Emotion Configuration

@emmatown emmatown merged commit c510d9d into next Aug 21, 2020
@emmatown emmatown deleted the small-changesets-cleanup branch August 21, 2020 20:40
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants