Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a console.warn to console.error for reporting bad rule insertion attempt in speedy mode #1811

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

Andarist
Copy link
Member

I don't think this deserves a changeset, just a small unification as we use console.error for most of the warnings/errors reported.

@Andarist Andarist requested a review from emmatown March 16, 2020 21:46
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2020

💥 No Changeset

Latest commit: 52da006

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 52da006:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #1811 into next will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/sheet/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown merged commit 6e5e4eb into next Mar 16, 2020
@emmatown emmatown deleted the unify-to-console-error branch March 16, 2020 22:12
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants