Clarify Vanilla Emotion auto-prefixing capabilities in documentation #1662
Conversation
💥 No ChangesetLatest commit: 10ba3fe Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
| @@ -63,10 +63,10 @@ The ["@emotion/core"](https://www.npmjs.com/package/@emotion/core) package requi | |||
|
|
|||
| - CSS prop support | |||
|
|
|||
| - Similar to the `style` prop but adds support for nested selectors, media queries, and auto-prefixing. | |||
There was a problem hiding this comment.
I understand how lack of this information in the previous section could be confusing - but was this one here confusing as well? I would keep this section as is - mention of style prop is kinda nice, it indicates how it looks like in the code.
There was a problem hiding this comment.
Upon re-reading this part of the code, I realize that I was associating the style prop with the framework agnostic section for some reason. Let me re-add this part.
docs/introduction.mdx
Outdated
|
|
||
| - Allows developers to skip the `styled` API abstraction and style components and elements directly. | ||
|
|
||
| - Similar to the `style` prop, but also has support for auto vendor-prefixing, nested selectors, and media queries. |
There was a problem hiding this comment.
Would prefer moving this to its former position (first in the list) - seems more important than the point about styled API.
|
Thank you! |
…motion-js#1662) * Update docs/introduction.mdx to be more clear with auto-prefixing support * Mention style prop again * Re-order bullet points in CSS prop usage
use `css` prop instaed. Ref: emotion-js/emotion#1662
Happy Thanksgiving everyone! fixes #1523
What:
I made this issue a while back where I had misconceptions about the capabilities of Vanilla Emotion. In this PR, I tidy up the docs a bit to hopefully erase these misconceptions (at least when read by me!).
Why:
These changes are needed to help Emotion users understand the capabilities of Vanilla vs React emotion better.
How:
Markdown changes!
Checklist: