Move @emotion/styled-base to @emotion/styled/base #1575
Conversation
🦋 Changeset is good to goLatest commit: ae18a8b We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
That’s great! Thanks |
| "module": "dist/styled.esm.js", | ||
| "umd:main": "dist/styled.umd.min.js", | ||
| "browser": { | ||
| "./dist/styled.cjs.js": "./dist/styled.browser.cjs.js", |
There was a problem hiding this comment.
i'm not entirely sure about it right now - but I vaguely remember at least some tools ignoring this alias field for extra entries, and that I had to include those redirects in root package.json
# Conflicts: # packages/styled-base/CHANGELOG.md # packages/styled-base/package.json # packages/styled/package.json # yarn.lock
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ae18a8b:
|
Andarist
force-pushed
the
styled-base-as-an-entrypoint
branch
from
f7c79e9 to
c66ce46
Compare
|
@mitchellhamilton I think this is nearly done, just surprisingly some flow errors popped up. I've asked @FezVrasta for help with this. |
# Conflicts: # package.json # packages/babel-plugin-emotion/__tests__/__snapshots__/styled.js.snap # packages/core/__tests__/css.js # packages/primitives/test/emotion-primitives.test.js # yarn.lock
* Change @emotion/styled-base to @emotion/styled/base * Fix some stuff * Fix some stuff * Fix another thing * Remove styled-base from CodeSandbox CI config * Make @emotion/styled/base TS types working * Restore flowtype tests for @emotion/styled/base * Fix last reference to @emotion/styled-base * fix some flow errors * Brought back @emotion/styled-base, but throw a deprecation error at runtime * fix styled Flow tests (emotion-js#1615) * fix flow type error * Add changeset * Update spotty-llamas-mate.md * Update index.js * Remove @emotion/styled-base from some changesets
What:
Move @emotion/styled-base to @emotion/styled/base
Why:
So that package authors who are using @emotion/styled and babel-plugin-emotion don't need to also add @emotion/styled-base to their dependencies.(if they didn't, their packages would not work in more strict package managers/bundlers)
How:
Use a Preconstruct entrypoint
Checklist: