Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭕(wip): shipment api and page #303

Merged
merged 42 commits into from
Feb 1, 2025
Merged

⭕(wip): shipment api and page #303

merged 42 commits into from
Feb 1, 2025

Conversation

emoss08
Copy link
Owner

@emoss08 emoss08 commented Jan 31, 2025

Summary by Sourcery

New Features:

  • Added a new shipment API and page.

@emoss08 emoss08 added enhancement New feature or request client Change to client application backend Change to backend application labels Jan 31, 2025
@emoss08 emoss08 self-assigned this Jan 31, 2025

This comment was marked as resolved.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 43.45469% with 730 lines in your changes missing coverage. Please review.

Project coverage is 14.69%. Comparing base (cddd7a3) to head (a083d6c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/services/shipment/service.go 0.00% 210 Missing ⚠️
...ructure/database/postgres/repositories/shipment.go 0.00% 158 Missing ⚠️
internal/api/handlers/shipment/handler.go 0.00% 131 Missing ⚠️
...tructure/database/postgres/repositories/usstate.go 0.00% 39 Missing ⚠️
...nal/infrastructure/external/maps/pcmiler/client.go 0.00% 37 Missing ⚠️
internal/api/handlers/routing/handler.go 0.00% 30 Missing ⚠️
internal/core/services/routing/service.go 0.00% 29 Missing ⚠️
internal/core/domain/shipment/shipment.go 78.50% 23 Missing ⚠️
...base/postgres/repositories/pcmilerconfiguration.go 0.00% 21 Missing ⚠️
internal/pkg/errors/errors.go 74.66% 18 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   12.22%   14.69%   +2.46%     
==========================================
  Files         192      206      +14     
  Lines       17938    19225    +1287     
==========================================
+ Hits         2193     2825     +632     
- Misses      15579    16214     +635     
- Partials      166      186      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sourcery-ai[bot]

This comment was marked as resolved.

@emoss08
Copy link
Owner Author

emoss08 commented Jan 31, 2025

@sourcery-ai summary

@emoss08
Copy link
Owner Author

emoss08 commented Jan 31, 2025

@sourcery-ai review

@emoss08
Copy link
Owner Author

emoss08 commented Jan 31, 2025

@sourcery-ai guide

sourcery-ai[bot]

This comment was marked as resolved.

@emoss08
Copy link
Owner Author

emoss08 commented Feb 1, 2025

We definitely need to change the map overlay for dark mode. I think the current overlay is fine for light mode.

Map View (Dark):

image

Map View (Light):

image

@emoss08
Copy link
Owner Author

emoss08 commented Feb 1, 2025

Still need to add markers, and the fix the indicator when the location pertaining to the shipment is not geocoded. It is important when in map view the origin location is geo coded to ensure the coordinates are correct when adding the shipment to the map. I'll also be adding a click action when the origin location is clicked in the map, it will pull up the order information and vice versa when in the sidebar

@emoss08
Copy link
Owner Author

emoss08 commented Feb 1, 2025

Need to figure out what other information I want to show in the shipment card. I could have a drop indicator where the user is allowed to show the data they want.

@emoss08 emoss08 changed the title ✅(add): shipment api and page ⭕(wip): shipment api and page Feb 1, 2025
@emoss08 emoss08 requested a review from wolfredstep February 1, 2025 23:42
@wolfredstep wolfredstep merged commit 7700696 into master Feb 1, 2025
5 checks passed
@wolfredstep wolfredstep deleted the shipment branch February 1, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to backend application client Change to client application enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants