Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves FileSet association to Work to the end of the ingest process (Bulkrax only). #1945

Merged
merged 7 commits into from
Sep 7, 2022

Conversation

bwatson78
Copy link
Contributor

  • app/actors/hyrax/actors/file_set_actor.rb: moves this callback to just after the FileSet/Work association point.
  • app/jobs/associate_filesets_with_work_job.rb: creates a separate job that associates all of the FileSets going into a work at once.
  • app/jobs/attach_files_to_work_job.rb: since we're processing the FileSet/Work association here instead of inside file_set_actor, this moves the callback to right after that association.
  • config/initializers/bulkrax.rb:
    • removes the index/number of files details as arguments since we're now doing the FileSet/Work association that needed that information to its own Job.
    • overrides the Bulkrax::ScheduleRelationshipsJob so that we can insert a call to the new AssociateFilesetsWithWorkJob at the end of the ingest process.
  • lib/importing_modules/file_set_methods.rb: deletes the FileSet/Work association process and the looping information needed for it to run from this point in the ingestion process.

@bwatson78 bwatson78 force-pushed the test_fileset_association_endjob branch from 4bb40df to 8857bd0 Compare September 6, 2022 18:08
@bwatson78 bwatson78 self-assigned this Sep 6, 2022
@bwatson78 bwatson78 marked this pull request as ready for review September 6, 2022 18:59
@bwatson78 bwatson78 merged commit 6cbfa22 into main Sep 7, 2022
@bwatson78 bwatson78 deleted the test_fileset_association_endjob branch September 7, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants