Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulkrax: preferred image logic should be applied when thumbs are generated #1944

Closed
eporter23 opened this issue Sep 1, 2022 · 2 comments
Closed
Assignees
Labels
Software Engineering Flag work for software engineering team

Comments

@eporter23
Copy link
Contributor

eporter23 commented Sep 1, 2022

When testing an image import in Bulkrax, I noticed that in some cases the preferred image logic is not being applied when the thumbnail is generated.

When an image-based Fileset has a preservation master file (original scan with color bars on the edges) and an intermediate file (cropped and straightened), the intermediate file should be used for the thumbnail. See more notes in prior tickets including #717.

Running a Regenerate Derivative job, however, does not correct this problem.

Correctly processed example:
https://curate-test.library.emory.edu/concern/parent/699n2z354t-cor/file_sets/313zs7h4f2-cor

Screen Shot 2022-09-01 at 12.36.07 PM.png

Incorrect example:
https://curate-test.library.emory.edu/concern/file_sets/146qz612vf-cor?locale=en

Screen Shot 2022-09-01 at 12.35.27 PM.png

@eporter23 eporter23 added the Software Engineering Flag work for software engineering team label Sep 1, 2022
@bwatson78 bwatson78 self-assigned this Sep 6, 2022
bwatson78 added a commit that referenced this issue Sep 6, 2022
…1944). (#1948)

* Sets the preferred file for derivatives before iterating over files.

* Makes rubocop happy.
@bwatson78
Copy link
Contributor

PR made: #1948

@eporter23
Copy link
Contributor Author

working well now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Software Engineering Flag work for software engineering team
Projects
None yet
Development

No branches or pull requests

2 participants