Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed use of '++' operator #3

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Fixed use of '++' operator #3

merged 1 commit into from
Jul 30, 2015

Conversation

jdlangs
Copy link
Contributor

@jdlangs jdlangs commented Jul 27, 2015

Hello,

In my investigation for JuliaLang/julia#11686 I found a usage of ++ in your package, which I'm pretty sure was an incorrect translation from C/C++. Now that it's merged, it causes a syntax error, so hopefully this the correct functionality you were hoping to have.

@emmt
Copy link
Owner

emmt commented Jul 29, 2015

Hello,

You are surely right. For the moment I am in vacations with no access to a real computer. So I cannot merge your fix. I'll do that as soon as possible.

Thank you for pointing this error,

�ric


De : Josh Langsfeld [notifications@github.com]
Envoy� : lundi 27 juillet 2015 23:43
� : emmt/OIFITS.jl
Objet : [OIFITS.jl] Fixed use of '++' operator (#3)

Hello,

In my investigation for JuliaLang/julia#11686JuliaLang/julia#11686 I found a usage of ++ in your package, which I'm pretty sure was an incorrect translation from C/C++. Now that it's merged, it causes a syntax error, so hopefully this the correct functionality you were hoping to have.


You can view, comment on, or merge this pull request online at:

#3

Commit Summary

  • Fixed use of '++' operator

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/3.

Lightjohn added a commit that referenced this pull request Jul 30, 2015
Fixed use of '++' operator
@Lightjohn Lightjohn merged commit e003345 into emmt:master Jul 30, 2015
@emmt
Copy link
Owner

emmt commented Jul 31, 2015

Merci Jonathan et bonnes vacances !
�ric


De : Jonathan [notifications@github.com]
Envoy� : jeudi 30 juillet 2015 11:05
� : emmt/OIFITS.jl
Cc : THIEBAUT ERIC
Objet : Re: [OIFITS.jl] Fixed use of '++' operator (#3)

Merged #3#3.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#event-369222325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants