Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use an async factory function for file instantiation #95

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 1, 2022

No description provided.

@emmercm emmercm self-assigned this Oct 1, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@74802e4). Click here to learn what that means.
The diff coverage is 93.33%.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage        ?   94.62%           
=======================================
  Files           ?       43           
  Lines           ?     1768           
  Branches        ?      347           
=======================================
  Hits            ?     1673           
  Misses          ?       90           
  Partials        ?        5           
Impacted Files Coverage Δ
src/modules/outputCleaner.ts 92.59% <0.00%> (ø)
src/modules/romScanner.ts 100.00% <ø> (ø)
src/modules/romWriter.ts 91.92% <88.23%> (ø)
src/types/files/file.ts 92.20% <91.30%> (ø)
src/modules/candidateGenerator.ts 100.00% <100.00%> (ø)
src/modules/headerProcessor.ts 100.00% <100.00%> (ø)
src/modules/scanner.ts 100.00% <100.00%> (ø)
src/types/archives/archive.ts 100.00% <100.00%> (ø)
src/types/archives/rar.ts 100.00% <100.00%> (ø)
src/types/archives/sevenZip.ts 95.65% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit 427ae91 into main Oct 1, 2022
@emmercm emmercm deleted the emmercm/file-static-factory branch October 1, 2022 00:24
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants