Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore status:nodump ROMs when merging & splitting #728

Merged
merged 4 commits into from
Oct 1, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 30, 2023

Fixes #724

@emmercm emmercm self-assigned this Sep 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 30, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/merge-split-ignore-nodump" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #728 (5356b24) into main (add9ec9) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   93.23%   93.54%   +0.30%     
==========================================
  Files          82       82              
  Lines        4984     4987       +3     
  Branches     1094     1094              
==========================================
+ Hits         4647     4665      +18     
+ Misses        319      305      -14     
+ Partials       18       17       -1     
Files Coverage Δ
src/modules/datMergerSplitter.ts 93.02% <100.00%> (+0.08%) ⬆️
src/types/dats/rom.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@emmercm emmercm marked this pull request as ready for review October 1, 2023 19:03
@emmercm emmercm merged commit 6e5b4e9 into main Oct 1, 2023
@emmercm emmercm deleted the emmercm/merge-split-ignore-nodump branch October 1, 2023 19:04
Copy link

github-actions bot commented Nov 1, 2023

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More mame merged set edge cases
1 participant