Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add {jelos} output token #698

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Feature: add {jelos} output token #698

merged 8 commits into from
Oct 6, 2023

Conversation

samwelnella
Copy link
Contributor

Updates gameConsole.ts, argumentsParser.ts and outputFactory.ts to add a {jelos} output token to support JELOS' directory structure

Updates gameConsole.ts, argumentsParser.ts and outputFactory.ts to add a {jelos} output token to support JELOS' directory structure
@samwelnella samwelnella changed the title Update gameConsole.ts for JELOS directory support Feature: Update gameConsole.ts for JELOS directory support Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:samwelnella/igir#main" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

src/types/outputFactory.ts Show resolved Hide resolved
@samwelnella
Copy link
Contributor Author

Hi, I've added new tests in outputFactory.test.ts for {jelos} based on the {batocera} tests

@samwelnella samwelnella requested a review from emmercm September 26, 2023 13:42
@emmercm emmercm changed the title Feature: Update gameConsole.ts for JELOS directory support Feature: add {jelos} output token Sep 27, 2023
@emmercm emmercm enabled auto-merge (squash) September 27, 2023 00:24
@emmercm emmercm disabled auto-merge September 27, 2023 00:44
@emmercm
Copy link
Owner

emmercm commented Sep 27, 2023

Hi @samwelnella, looks like there are some syntax errors reported by CI.

auto-merge was automatically disabled October 4, 2023 03:48

Head branch was pushed to by a user without write access

@samwelnella
Copy link
Contributor Author

samwelnella commented Oct 5, 2023

Hi, @emmercm, I think I fixed the issue but some tests have been stuck with "Expected" status for a while. I'm not sure what to do.

@emmercm emmercm enabled auto-merge (squash) October 5, 2023 04:46
@emmercm
Copy link
Owner

emmercm commented Oct 5, 2023

Hi @samwelnella, it's entirely a GitHub security setting that doesn't have fine-grained control. Users that aren't marked as repository collaborators can't initiate some workflows, to prevent secrets from being exported by malicious actors. I'll make sure the tests get triggered.

@emmercm emmercm mentioned this pull request Oct 5, 2023
@emmercm
Copy link
Owner

emmercm commented Oct 5, 2023

@samwelnella I'm fighting some unit tests that keep failing in macOS, I'm going to need to debug. I think there's a potential bug being caused by #630.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #698 (d82bd39) into main (c044b39) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   93.66%   93.65%   -0.02%     
==========================================
  Files          83       83              
  Lines        5038     5044       +6     
  Branches     1128     1129       +1     
==========================================
+ Hits         4719     4724       +5     
  Misses        302      302              
- Partials       17       18       +1     
Files Coverage Δ
src/modules/argumentsParser.ts 98.11% <ø> (ø)
src/types/gameConsole.ts 100.00% <100.00%> (ø)
src/types/outputFactory.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@emmercm emmercm merged commit f29dcfb into emmercm:main Oct 6, 2023
Copy link

github-actions bot commented Nov 5, 2023

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants