-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add {jelos} output token #698
Conversation
Updates gameConsole.ts, argumentsParser.ts and outputFactory.ts to add a {jelos} output token to support JELOS' directory structure
🧪 Branch TestingThis pull request can be tested locally with the following command: npm exec --yes -- "github:samwelnella/igir#main" [commands..] [options] Comment generated by the Pull Request Commenter workflow. |
Hi, I've added new tests in |
Hi @samwelnella, looks like there are some syntax errors reported by CI. |
Head branch was pushed to by a user without write access
Hi, @emmercm, I think I fixed the issue but some tests have been stuck with "Expected" status for a while. I'm not sure what to do. |
Hi @samwelnella, it's entirely a GitHub security setting that doesn't have fine-grained control. Users that aren't marked as repository collaborators can't initiate some workflows, to prevent secrets from being exported by malicious actors. I'll make sure the tests get triggered. |
@samwelnella I'm fighting some unit tests that keep failing in macOS, I'm going to need to debug. I think there's a potential bug being caused by #630. |
Codecov Report
@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 93.66% 93.65% -0.02%
==========================================
Files 83 83
Lines 5038 5044 +6
Branches 1128 1129 +1
==========================================
+ Hits 4719 4724 +5
Misses 302 302
- Partials 17 18 +1
|
🔒 Inactive pull request lockThis pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Comment generated by the GitHub Lock Issues workflow. |
Updates gameConsole.ts, argumentsParser.ts and outputFactory.ts to add a {jelos} output token to support JELOS' directory structure