Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: catch & log ROM header processing exceptions #685

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 22, 2023

No description provided.

@emmercm emmercm self-assigned this Sep 22, 2023
@emmercm emmercm enabled auto-merge (squash) September 22, 2023 23:20
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #685 (22c0f8f) into main (2e609e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   93.44%   93.45%           
=======================================
  Files          82       82           
  Lines        4853     4856    +3     
  Branches     1056     1056           
=======================================
+ Hits         4535     4538    +3     
  Misses        301      301           
  Partials       17       17           
Files Changed Coverage Δ
src/modules/romHeaderProcessor.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/header-processor-catch" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 1c9366d into main Sep 22, 2023
@emmercm emmercm deleted the emmercm/header-processor-catch branch September 22, 2023 23:35
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant