Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace adm-zip with yazl & yauzl, fix global temp folder #68

Merged
merged 33 commits into from
Sep 22, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 22, 2022

No description provided.

@emmercm emmercm self-assigned this Sep 22, 2022
@emmercm emmercm changed the title Refactor: replace adm-zip with yazl & yauzl Refactor: replace adm-zip with yazl & yauzl, fix global temp folder Sep 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #68 (7e04a95) into main (e5bb4e5) will increase coverage by 0.41%.
The diff coverage is 91.48%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   94.53%   94.95%   +0.41%     
==========================================
  Files          43       43              
  Lines        1628     1664      +36     
  Branches      326      331       +5     
==========================================
+ Hits         1539     1580      +41     
+ Misses         85       81       -4     
+ Partials        4        3       -1     
Impacted Files Coverage Δ
src/modules/candidateFilter.ts 100.00% <ø> (ø)
src/modules/candidateGenerator.ts 100.00% <ø> (ø)
src/modules/datScanner.ts 100.00% <ø> (ø)
src/types/archives/archive.ts 100.00% <ø> (ø)
src/polyfill/fsPoly.ts 89.65% <83.33%> (+0.56%) ⬆️
src/types/archives/zip.ts 90.54% <90.00%> (+0.06%) ⬆️
src/modules/romWriter.ts 93.70% <90.47%> (+5.01%) ⬆️
src/constants.ts 90.90% <100.00%> (ø)
src/modules/headerProcessor.ts 95.83% <100.00%> (ø)
src/types/archives/rar.ts 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit 1ec8633 into main Sep 22, 2022
@emmercm emmercm deleted the emmercm/yazl-yauzl branch September 22, 2022 23:54
emmercm added a commit that referenced this pull request Sep 23, 2022
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants