Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rename UNMATCHED report status to UNUSED #668

Merged
merged 4 commits into from
Sep 23, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 19, 2023

RE: #654

@emmercm emmercm self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dat-status-unused" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm changed the title Breaking: rename UNMATCHED report status to UNUSED Fix: rename UNMATCHED report status to UNUSED Sep 21, 2023
@emmercm emmercm marked this pull request as ready for review September 23, 2023 02:03
@emmercm emmercm enabled auto-merge (squash) September 23, 2023 02:04
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #668 (210280c) into main (8688d68) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          82       82           
  Lines        4867     4867           
  Branches     1057     1057           
=======================================
  Hits         4549     4549           
  Misses        301      301           
  Partials       17       17           
Files Changed Coverage Δ
src/modules/reportGenerator.ts 100.00% <100.00%> (ø)
src/types/datStatus.ts 97.90% <100.00%> (ø)

@emmercm emmercm merged commit a9f7353 into main Sep 23, 2023
@emmercm emmercm deleted the emmercm/dat-status-unused branch September 23, 2023 02:22
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant