Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dir letter of games with multiple ROMs #613

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 25, 2023

No description provided.

@emmercm emmercm self-assigned this Aug 25, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dir-letter-fix" [commands..] [options]

@codecov-commenter
Copy link

Codecov Report

Merging #613 (3ac844c) into main (2825d6b) will decrease coverage by 0.36%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   93.64%   93.29%   -0.36%     
==========================================
  Files          77       77              
  Lines        4548     4548              
  Branches      979      979              
==========================================
- Hits         4259     4243      -16     
- Misses        276      290      +14     
- Partials       13       15       +2     
Files Changed Coverage Δ
src/types/logiqx/dat.ts 96.29% <100.00%> (ø)
src/types/outputFactory.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@emmercm emmercm enabled auto-merge (squash) August 25, 2023 14:01
@emmercm emmercm merged commit 76c9f63 into main Aug 25, 2023
@emmercm emmercm deleted the emmercm/dir-letter-fix branch August 25, 2023 19:01
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants