Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: eliminate TypeScript "as" keyword #573

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 15, 2023

No description provided.

@emmercm emmercm self-assigned this Aug 15, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/20230814-eliminate-as" [commands..] [options]

@emmercm emmercm marked this pull request as ready for review August 18, 2023 21:06
@emmercm emmercm enabled auto-merge (squash) August 18, 2023 21:06
@codecov-commenter
Copy link

Codecov Report

Merging #573 (90f666c) into main (51cb6fc) will decrease coverage by 0.08%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   93.62%   93.54%   -0.08%     
==========================================
  Files          76       77       +1     
  Lines        4562     4538      -24     
  Branches      978      977       -1     
==========================================
- Hits         4271     4245      -26     
- Misses        277      279       +2     
  Partials       14       14              
Files Changed Coverage Δ
src/modules/candidatePatchGenerator.ts 95.00% <ø> (-0.07%) ⬇️
src/modules/candidateWriter.ts 88.99% <ø> (ø)
src/modules/datScanner.ts 94.44% <ø> (-0.04%) ⬇️
src/modules/directoryCleaner.ts 96.36% <ø> (-0.07%) ⬇️
src/modules/movedRomDeleter.ts 94.64% <ø> (-0.10%) ⬇️
src/modules/reportGenerator.ts 100.00% <ø> (ø)
src/types/internationalization.ts 100.00% <ø> (ø)
src/types/logiqx/game.ts 97.45% <ø> (-0.04%) ⬇️
src/types/options.ts 98.34% <ø> (-0.02%) ⬇️
src/types/patches/patchFactory.ts 100.00% <ø> (ø)
... and 14 more

@emmercm emmercm merged commit a0636ac into main Aug 18, 2023
@emmercm emmercm deleted the emmercm/20230814-eliminate-as branch August 18, 2023 22:19
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants