Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: progress bar can't have negative "in progress" value #558

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 6, 2023

Fixes #557

@emmercm emmercm self-assigned this Aug 6, 2023
@emmercm emmercm enabled auto-merge (squash) August 6, 2023 16:43
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/557-fix" [commands..] [options]

@codecov-commenter
Copy link

Codecov Report

Merging #558 (9e4a539) into main (38bf781) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   93.62%   93.60%   -0.02%     
==========================================
  Files          75       75              
  Lines        4501     4505       +4     
  Branches      958      960       +2     
==========================================
+ Hits         4214     4217       +3     
- Misses        273      274       +1     
  Partials       14       14              
Files Changed Coverage Δ
src/console/singleBarFormatted.ts 80.80% <88.88%> (-0.25%) ⬇️

@emmercm emmercm merged commit 6056738 into main Aug 6, 2023
@emmercm emmercm deleted the emmercm/557-fix branch August 6, 2023 16:59
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid count value error
2 participants