Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: trim whitespaces from the fixdat filename #548

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 4, 2023

No description provided.

@emmercm emmercm self-assigned this Aug 4, 2023
@emmercm emmercm enabled auto-merge (squash) August 4, 2023 00:20
@codecov-commenter
Copy link

Codecov Report

Merging #548 (76082c9) into main (ecd5d28) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          75       75           
  Lines        4445     4446    +1     
  Branches      938      938           
=======================================
+ Hits         4158     4159    +1     
  Misses        273      273           
  Partials       14       14           
Files Changed Coverage Δ
src/modules/fixdatCreator.ts 100.00% <ø> (ø)
src/types/logiqx/dat.ts 94.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fixdat-name-trimming" [commands..] [options]

@emmercm emmercm merged commit d1ca453 into main Aug 4, 2023
@emmercm emmercm deleted the emmercm/fixdat-name-trimming branch August 4, 2023 02:15
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants