Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: report & progress bar status respect ROM filters #532

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 29, 2023

No description provided.

@emmercm emmercm self-assigned this Jul 29, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dat-status-respects-filters" [commands..] [options]

@emmercm emmercm enabled auto-merge (squash) July 29, 2023 05:41
@emmercm emmercm disabled auto-merge July 29, 2023 06:10
@emmercm emmercm enabled auto-merge (squash) July 29, 2023 06:46
@codecov-commenter
Copy link

Codecov Report

Merging #532 (fad4eb5) into main (903acd0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   93.56%   93.54%   -0.03%     
==========================================
  Files          75       75              
  Lines        4445     4445              
  Branches      938      938              
==========================================
- Hits         4159     4158       -1     
- Misses        272      273       +1     
  Partials       14       14              
Files Changed Coverage Δ
src/types/datStatus.ts 97.72% <100.00%> (-0.81%) ⬇️
src/types/logiqx/game.ts 98.08% <100.00%> (+0.02%) ⬆️

@emmercm emmercm merged commit 6ed395a into main Jul 29, 2023
@emmercm emmercm deleted the emmercm/dat-status-respects-filters branch July 29, 2023 07:16
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants